Fix String Compatibility Issues in BleMouse.cpp Library #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the compatibility issues between std::string and Arduino String types in the BleMouse library. Modifications have been made to `BleMouse.cpp` to ensure that std::string is properly converted to Arduino String where necessary. These changes ensure that the library functions correctly with Arduino IDE Version 2.2.1 and the developer version of the Arduino-ESP32 library (Arduino Alpha 2 Release v3.0.0 based on ESP-IDF v5.1). The library has been tested and verified to work as expected with this setup.
|
Can confirm. This works in the Arduino IDE: And |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the compatibility issues between std::string and Arduino String types in the BleMouse library. Modifications have been made to
BleMouse.cppto ensure that std::string is properly converted to Arduino String where necessary. These changes ensure that the library functions correctly with Arduino IDE Version 2.2.1 and the developer version of the Arduino-ESP32 library (Arduino Alpha 2 Release v3.0.0 based on ESP-IDF v5.1). The library has been tested and verified to work as expected with this setup.