Fix Assembly property of UnavailableType #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assembly was the one in which the type was referenced instead of the assembly containing the type. Issue: TNG#430 Signed-off-by: Jean-Philippe Durot <[email protected]>
jpdurot
force-pushed
the
unavailabletpye-assembly
branch
from
7f95040 to
5049968
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 74.84% 74.82% -0.02%
==========================================
Files 257 257
Lines 17221 17225 +4
Branches 1575 1575
==========================================
Hits 12889 12889
- Misses 3876 3880 +4
Partials 456 456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Hi @jpdurot, thanks for the improvement here. As soon as you've fixed the formatting issue, I'll merge this for the next version. |
alexanderlinne
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #430
Fix on
UnavailableType.Equalsmethod was not revealed by the automatic tests but from usage with my real assemblies(Equals calls itself leading to an infinite loop).