Refactor attribute with arguments fluent syntax methods #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 74.86% 73.71% -1.15%
==========================================
Files 257 258 +1
Lines 17221 16374 -847
Branches 1575 1338 -237
==========================================
- Hits 12892 12070 -822
- Misses 3873 3887 +14
+ Partials 456 417 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
refactor/attribute-with-arguments-syntax-elements
branch
from
38d7e45 to
2edbb5a
Compare
mak638
reviewed
Nov 29, 2025
| @@ -0,0 +1,48 @@ | |||
| using System; | |||
Collaborator
There was a problem hiding this comment.
nitpick: using System; is unnecessary
mak638
reviewed
Nov 29, 2025
| { | ||
| var attArguments = instance | ||
| .GetAllNamedAttributeArgumentTuples() | ||
| .ToList(); |
Collaborator
There was a problem hiding this comment.
I noticed you are using .ToList() in many places in this file where it would not be necessary. Maybe it would be worth it to have a second look as leaving out the unnecessary conversions into lists could increase the performance massively.
mak638
reviewed
Nov 29, 2025
| return $"{instance.Type.FullName} {argumentsDescription}"; | ||
| }); | ||
| var failDescription = argumentsDescriptions.FormatDescription( | ||
| "does not have any attribute", |
Collaborator
There was a problem hiding this comment.
nitpick: Missing 's' at the end - "does not have any attributes"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute(s)With(Named)Argumentsfluent syntax methods and reduce code duplication by refactoring common logic into helper methods.AttributesWithArgumentswe only keep theIEnumerable<object>overload and remove theparams object[]overload to remove the type ambiguity.