-
-
Notifications
You must be signed in to change notification settings - Fork 417
feat: add cached thumb quality and resolution settings #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My personal thought on the subject is that we should add a toggle like "Advanced Settings" or "Advanced Mode" and give user access to more internal settings like theses. Or else documents them on the docs.tagstud.io/ website. |
I agree - I plan on adding a page on the docs site going over the settings in-depth soon as there's now a good amount of them. And future UI rework of the settings panel could definitely include an "Advanced" toggle to show additional detailed settings in-app. For now though, this PR at least gets the features in the program and can be integrated with a UI PR at a later date and be included on the docs site in the meantime. |
What do you think about just adding another tab that is literally called "Advanced"? For me that would be clear enough and also out of the way. (We could also always add a warning or something at the top if that is deemed necessary) |
There's actually a couple other aspects I'd like to change/add first, one being the proper addition of "Library" settings that are separate from the "Application" settings and also have a default overrideable configuration, and the other being something like a horizontal tab breakup of the settings to put things into categories as the number of settings increases (i.e. "UI", "Search", "Behavior", etc. where applicable. While an "Advanced" tab would work with the current UI, it would be another thing that would need to be refactored before more changes like that, since having those settings in their own tab would go against the "Application/[Possibly Default Library]/Library" main tab setup I have in mind to replace the current "Global aka Application"-only tab with. |
Summary
This adds two new settings to the config file:
cached_thumb_quality
which controls the amount of compression used in the cached .webp images, andcached_thumb_resolution
which determines the maximum dimension of a cached thumbnail image. This also fixes an uncaught exception that occurred when deleting the inner thumbs folder(s) on disk while the program was running.After #1084 I've been toying with the idea of making certain power-user focused settings such as these only accessible in the config file in an attempt to keep clutter in the GUI down. Organization of the settings UI as more settings are introduced is outside the scope of this PR though, the important note is that I'm just adding these as config only options at the moment and am open to reconsidering that in the future.
Closes #802
Tasks Completed