refactor: fix most pyright issues in library/alchemy/
#1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Refactor
CyanVoxel
added
Priority: High
8 tasks
Comment on lines
172
to
173
| case _: | ||
| pass |
Collaborator
There was a problem hiding this comment.
I would throw an exception here instead since an unhandled Constraint would lead to an incorrect query and no ConstraintType should ever be unhandled
Member
Author
There was a problem hiding this comment.
I agree, that makes sense - however... I'm now realizing that there are 9 of our test cases failing due to falling under this case:
FAILED tests/test_search.py::test_and[orange and filetype:png-5] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_and[square and filetype:jpg-2] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_and[orange filetype:png-5] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_and[green path:*inherit*-4] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_or[filetype:jpg or tag:orange-11] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_or[red or filetype:png-28] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_or[filetype:jpg or path:*comp*-11] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_not[special:untagged or not filetype:jpg-26] - NotImplementedError: Unhandled constraint
FAILED tests/test_search.py::test_parentheses[filetype:png and (tag:square or green)-12] - NotImplementedError: Unhandled constraint
Member
Author
There was a problem hiding this comment.
Doing slightly some more digging and this appears to be for the cases of ConstraintType.FileType, ConstraintType.Path, and one ConstraintType.Special. I think I could just add those into the switch and give them passes? Since that was effectively the behavior before, and an exception will still be raised for anything new or unexpected coming through
Computerdores
approved these changes
Sep 6, 2025
Computerdores
moved this from 🏓 Ready for Review
to 🍃 Pending Merge
in TagStudio Development
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
This was referenced Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A version of #1067 that addresses the same Pyright issues in
src/tagstudio/core/library/alchemy/, minus the large refactoring due to thereportImportCycleserror.Tasks Completed