Skip to content

feat: clickable links in text fields #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: clickable links in text fields #924

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1e05eb
feat: links in text fields are clickable
TrigamDev Apr 25, 2025
5bca276
style: fix linting errors
TrigamDev Apr 25, 2025
31cff34
style: remove unnecessary comment
TrigamDev Apr 25, 2025
fe3bcc9
feat: better url pattern
TrigamDev Apr 25, 2025
c377938
chore: disable Ruff error
TrigamDev Jun 7, 2025
bdebe10
style: add trailing line
TrigamDev Jun 7, 2025
f939ce7
style: maybe format it? that'd be smart
TrigamDev Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/tagstudio/qt/widgets/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# Created for TagStudio: https://github.com/CyanVoxel/TagStudio


import re

from PySide6.QtCore import Qt
from PySide6.QtWidgets import QHBoxLayout, QLabel

Expand All @@ -19,9 +21,22 @@ def __init__(self, title, text: str) -> None:
self.text_label = QLabel()
self.text_label.setStyleSheet("font-size: 12px")
self.text_label.setWordWrap(True)
self.text_label.setTextInteractionFlags(Qt.TextInteractionFlag.TextSelectableByMouse)
self.text_label.setTextFormat(Qt.TextFormat.RichText)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer setting this to markdown, as (afaik) the long term plan is to have WYSIWYG markdown editing for various fields. This would also mean changing the substitution further down.

(Or not setting it at all so that people don't get used to / have their libraries heavily use RichText Formatting)

self.text_label.setOpenExternalLinks(True)
self.text_label.setTextInteractionFlags(Qt.TextInteractionFlag.TextBrowserInteraction)
self.base_layout.addWidget(self.text_label)
self.set_text(text)

def set_text(self, text: str):
text = linkify(text)
self.text_label.setText(text)

# Regex from https://stackoverflow.com/a/6041965
def linkify(text: str):
url_pattern = r"(http|ftp|https):\/\/([\w_-]+(?:(?:\.[\w_-]+)+))([\w.,@?^=%&:\/~+#-*]*[\w@?^=%&\/~+#-*])"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recognising file:// be desirable as well? Because major browsers support that as well

Copy link

@ToxicMushroom ToxicMushroom Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think compiling this regex with re.compile() once and storing it as a global might make it quicker, thought ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point

return re.sub(
url_pattern,
lambda url: f'<a href="{url.group(0)}">{url.group(0)}</a>',
text,
flags=re.IGNORECASE
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing trailing new line

Loading