refactor(preview_thumb): mvc split #978
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
added
Type: Refactor
Computerdores
force-pushed
the
refactor/mvc-split-preview-thumb
branch
from
a7627e8 to
623add4
Compare
Computerdores
force-pushed
the
refactor/mvc-split-preview-thumb
branch
from
623add4 to
2b6d5ae
Compare
Computerdores
moved this from 🚧 In progress
to 🏓 Ready for Review
in TagStudio Development
|
This is ready for review now (I would recommend waiting with the review until #952 is merged and this PR is rebased onto main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits the current preview thumb into View and Controller in accordance with the now accepted proposal in #950.
Note: This is based off #952 and will need to be rebased once that is merged.
Note: I preserved the change history for both
preview_thumb_controller.pyandpreview_thumb_view.pyvia those first 3 commits, however this breaks if all commits are squashed. This means we can either not preserve the change history for those files and squash all of the commits in this PR, or we only squash the commits after that (I could do that myself, as it would require splitting the changes from the following commits and then merging after).Tasks Completed