feat: click tags in tag library to edit #987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After discussion in #426, it's been agreed a single left-click of a tag in the tab library should open the edit modal.
There is some discussion of a larger refactor, and while I think there is room for improvement with
TagWidgetand how it's used, this is more of a quick fix adding the functionality as it is currently intended.I also removed all type errors and warnings in the file, though my techniques for doing so may not be the best. Would be happy to hear suggestions for improvement. These changes are all in the second commit if you'd like to see them (or the functional changes) in isolation.
Tasks Completed