Skip to content

Conversation

samwillis
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 13d9d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tanstack/react-db Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 11, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@535

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@535

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@535

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@535

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@535

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@535

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@535

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@535

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@535

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@535

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@535

commit: 13d9d0d

@samwillis samwillis force-pushed the samwillis/use-live-query-return-null branch from 8648213 to 24fccb5 Compare September 11, 2025 18:02
@samwillis samwillis requested a review from thruflo September 11, 2025 18:05
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Size Change: 0 B

Total Size: 68.4 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection-events.js 672 B
./packages/db/dist/esm/collection.js 10.9 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/index.js 1.55 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.02 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 3.93 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.52 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.08 kB
./packages/db/dist/esm/query/compiler/index.js 2.27 kB
./packages/db/dist/esm/query/compiler/joins.js 2.52 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.23 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 508 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.59 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.4 kB
./packages/db/dist/esm/query/optimizer.js 3.05 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 3.03 kB
./packages/db/dist/esm/utils.js 943 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

Copy link
Contributor

github-actions bot commented Sep 11, 2025

Size Change: 0 B

Total Size: 1.18 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.02 kB

compressed-size-action::react-db-package-size

Copy link
Collaborator

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great!

if (result === undefined || result === null) {
// Callback returned undefined/null - disabled query
collectionRef.current = null
} else if (result instanceof CollectionImpl) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice to have a isCollection

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left isCollection and isQueryBuilder for a followup, there is some ambiguity on when each should be set as everything becomes a collection at the end.

// Callback returned a Collection instance - use it directly
result.startSyncImmediate()
collectionRef.current = result
} else if (result instanceof BaseQueryBuilder) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and isQueryBuilder

@samwillis samwillis merged commit 65b078a into main Sep 18, 2025
6 checks passed
@samwillis samwillis deleted the samwillis/use-live-query-return-null branch September 18, 2025 10:02
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants