fix(solid-form): fix props reactivity in withForm and withFieldGroupInitialized Repository#2058
Merged
crutchcorn merged 3 commits intoTanStack:mainfrom Mar 4, 2026
Conversation
- Replace object spread with mergeProps() to preserve reactive getters - Call render via createComponent() to maintain SolidJS reactive context - Add regression tests for withForm and withFieldGroup reactivity
- Replace object spread with mergeProps() to preserve reactive getters - Call render via createComponent() to maintain SolidJS reactive context - Add regression tests for withForm and withFieldGroup reactivity Fixes TanStack#2054
🦋 Changeset detectedLatest commit: 1b15b84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 1b15b84
☁️ Nx Cloud last updated this comment at |
crutchcorn
approved these changes
Mar 4, 2026
Member
crutchcorn
left a comment
crutchcorn
left a comment
There was a problem hiding this comment.
This makes sense to me! Thanks for this! Let me run some CI/CD checks and we'll merge after
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2058 +/- ##
==========================================
+ Coverage 90.35% 95.49% +5.14%
==========================================
Files 38 4 -34
Lines 1752 111 -1641
Branches 444 9 -435
==========================================
- Hits 1583 106 -1477
+ Misses 149 5 -144
+ Partials 20 0 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fix props passed to
withFormandwithFieldGroupcomponents not being reactive. (closes #2054)withFormandwithFieldGroupused object spread ({ ...props, ...innerProps })to pass props to the
renderfunction.In SolidJS, JSX props are passed as getter functions internally.
Object spread eagerly evaluates those getters and copies only the resulting values,
which breaks signal tracking.
As a result, even when the parent updates a signal, createEffect inside render
never re-runs and the JSX never updates.
Replace object spread with mergeProps() to preserve the reactive getters,
and call render via createComponent() to maintain the correct SolidJS
reactive context.
The same fix is applied to withFieldGroup.
Add regression tests to verify JSX reactivity and
createEffectre-runswhen signal props change in
withFormandwithFieldGroup.✅ Checklist
🚀 Release Impact