fix(query-core) Fix queries argument's type definition in queriesObserver #9449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queries
argument is not typed consistently in many of the methods inqueriesObserver
class. The constructor typed it to beArray<QueryObserverOptions<any, any, any, any, any>>
but in few other places it'sArray<QueryObserverOptions>
which means the default will kick in, making itArray<QueryObserverOptions<unknown, DefaultError, unknown, unknown, QueryKey>
.This caused issues when I try to interact with queryObserver:
In the fix, I used the same type that the constructor takes in for queryOptions in
setQueries
and a few other places.