test(solid-query/useQuery): migrate to fake timers, replace 'waitFor' with 'advanceTimersByTimeAsync', and improve 'queryFn' patterns by sukvvon · Pull Request #9894 · TanStack/query

sukvvon · 2025-11-23T10:11:48Z

🎯 Changes

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

…sByTimeAsync', add 'expect().toBeInTheDocument()', convert sync 'queryFn' to 'sleep().then()', and add detailed timing comments

changeset-bot · 2025-11-23T10:11:52Z

⚠️ No Changeset found

Latest commit: 948599d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-11-23T10:11:53Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)

packages/solid-query/src/tests/useQuery.test.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-11-23T10:12:16Z

View your CI Pipeline Execution ↗ for commit 948599d

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	43s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-15 11:50:22 UTC

pkg-pr-new · 2025-11-23T10:13:19Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9894

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9894

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9894

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9894

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9894

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9894

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9894

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9894

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9894

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9894

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9894

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9894

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9894

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9894

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9894

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9894

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9894

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9894

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9894

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9894

commit: 948599d

codecov · 2025-11-23T10:14:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.63%. Comparing base (f15b7fc) to head (948599d).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9894       +/-   ##
===========================================
+ Coverage   45.89%   76.63%   +30.74%     
===========================================
  Files         200       19      -181     
  Lines        8437      398     -8039     
  Branches     1943       83     -1860     
===========================================
- Hits         3872      305     -3567     
+ Misses       4116       76     -4040     
+ Partials      449       17      -432

Components	Coverage Δ
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`77.81% <ø> (ø)`
@tanstack/solid-query-devtools	`64.17% <ø> (ø)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…)' pattern in queryFn

… to async/await pattern

sukvvon · 2025-12-15T11:44:31Z

@TkDodo

I converted complex then callbacks (with multiple statements like variable increments, conditionals, or throws) to async/await pattern, while keeping simple one-liner then callbacks (e.g., sleep(10).then(() => 'data')) as-is for conciseness.

Was this what you had in mind?

…imers-and-improve-assertions

test(solid-query/useQuery): migrate to fake timers with 'advanceTimer…

4388172

…sByTimeAsync', add 'expect().toBeInTheDocument()', convert sync 'queryFn' to 'sleep().then()', and add detailed timing comments

github-actions bot added the package: solid-query label Nov 23, 2025

sukvvon marked this pull request as ready for review November 23, 2025 10:15

sukvvon added 2 commits November 24, 2025 02:12

test(solid-query/useQuery): replace 'async/await' with 'sleep().then(…

4ffb3e0

…)' pattern in queryFn

refactor(solid-query/useQuery.test): convert complex 'then' callbacks…

a6d8403

… to async/await pattern

Merge branch 'main' into test/solid-query-use-query-migrate-to-fake-t…

948599d

…imers-and-improve-assertions

TkDodo merged commit 7a3990e into TanStack:main Dec 27, 2025
9 checks passed

sukvvon self-assigned this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(solid-query/useQuery): migrate to fake timers, replace 'waitFor' with 'advanceTimersByTimeAsync', and improve 'queryFn' patterns#9894

test(solid-query/useQuery): migrate to fake timers, replace 'waitFor' with 'advanceTimersByTimeAsync', and improve 'queryFn' patterns#9894
TkDodo merged 4 commits intoTanStack:mainfrom
sukvvon:test/solid-query-use-query-migrate-to-fake-timers-and-improve-assertions

sukvvon commented Nov 23, 2025

Uh oh!

changeset-bot bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 23, 2025 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

sukvvon commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Nov 23, 2025

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sukvvon commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Nov 23, 2025 •

edited

Loading

coderabbitai bot commented Nov 23, 2025 •

edited

Loading

nx-cloud bot commented Nov 23, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 23, 2025 •

edited

Loading

codecov bot commented Nov 23, 2025 •

edited

Loading