-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(e2e): add failing e2e test for server function middleware retries #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test(e2e): add failing e2e test for server function middleware retries #4738
Conversation
would it make sense to return something else per invocation? so that we can count how often the function was called. like increasing a counter? |
View your CI Pipeline Execution ↗ for commit 11e6545
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
I thought of this but I found it surprisingly not trivial to do elegantly, as I don't think I can access the return value from I can add a global variable like this? But that is going to be fragile when called multiple times (hence the added condition to reset the count when it reaches 4...), I assume this is not what you're looking for, if you have a suggestion happy to apply it |
be6cbb5
to
8423b74
Compare
Or I guess I just ignore the type error and use the context like this... hard to check if the test is well formed without the ability to run it properly :D |
Adds failing e2e test for #4737