Skip to content

Fix repo path validation for framework-specific route segments #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −1
Open

Fix repo path validation for framework-specific route segments #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120d802
Fix repo path validation for framework-specific route segments
sentry[bot] Aug 29, 2026
b793716
ci: apply automated fixes
autofix-ci[bot] Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/repo-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export const MAX_REPO_PATH_LENGTH = 512

const REPO_PATH_SEGMENT_PATTERN = /^[a-zA-Z0-9._$+-]+$/
const REPO_PATH_SEGMENT_PATTERN = /^[a-zA-Z0-9._$+\-\[\]()@]+$/

Check warning on line 3 in src/utils/repo-path.ts

View workflow job for this annotation

GitHub Actions / PR

eslint(no-useless-escape) 

Unnecessary escape character '['

export function isValidRepoPath(path: string) {
if (path === '') {
Expand Down
18 changes: 18 additions & 0 deletions tests/repo-path.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,24 @@ assert.equal(
'query delimiters are rejected',
)

assert.equal(
isValidRepoPath('examples/svelte/basic/src/routes/[postId]/+page.svelte'),
true,
'SvelteKit bracket-style dynamic route segments are valid repo path segments',
)

assert.equal(
isValidRepoPath('examples/react/start-basic/src/routes/(auth)/login.tsx'),
true,
'Next.js/Remix parenthesis route group segments are valid repo path segments',
)

assert.equal(
isValidRepoPath('examples/react/start-basic/src/@components/Button.tsx'),
true,
'at-sign path segments are valid repo path segments',
)

assert.equal(
joinRepoPath('examples/react/start-basic', 'src/routes/__root.tsx'),
'examples/react/start-basic/src/routes/__root.tsx',
Expand Down
Loading