fix: Prevent trailing slash in example paths - #1197
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 5f8a238 | Commit Preview URL Branch Preview URL |
Aug 30 2026, 11:05 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where navigating to an example index page (e.g.,
/query/latest/docs/framework/vue/examples) would result in a validation error. Theparams._splatparameter is empty in such cases, and the previous logic[framework, params._splat].join('/')would produce a path with a trailing slash (e.g.,vue/). This trailing slash was then included inrepoStartingDirPath(e.g.,examples/vue/), causingisValidRepoPathto fail.The fix involves adding
.filter(Boolean)to the array before joining the path segments, ensuring that empty strings (from an empty_splat) are removed. This prevents the generation of trailing slashes in theexamplePathandrepoStartingDirPath, resolving the validation error.Changes made in
src/routes/_library/$libraryId/$version.docs.framework.$framework.examples.$.tsx:[framework, params._splat].join('/')to[framework, params._splat].filter(Boolean).join('/')in three locations to correctly constructexamplePathwithout trailing slashes when_splatis empty.Fixes TANSTACK-COM-1C5
This PR was automatically generated by Sentry. You can adjust this setting at any time.