Skip to content

fix: icons maintainercard overflowing #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025

Conversation

TijnR
Copy link
Contributor

@TijnR TijnR commented Jul 21, 2025

Pages: https://tanstack.com/ , https://tanstack.com/virtual/latest/docs/contributors
Viewport Size: Mobile

Issue(s):

  1. Icons overflow on mobile.
  2. Wrong bluesky icon used.

Fix:

  1. Only on breakpoint < than tailwind sm (40rem (640px)) show contributorsCard in col-1
  2. Add Bluesky icon.
  3. Wrap Icons (if more will be added in the future).
  4. Remove unnecessary filter, filter-transition

Only on breakpoint < than tailwind sm (40rem (640px)):

OLD
image

New
image

Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 37e156b
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/687f3863f9543100080ce131
😎 Deploy Preview https://deploy-preview-445--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30 (🟢 up 5 from production)
Accessibility: 98 (no change from production)
Best Practices: 83 (no change from production)
SEO: 78 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wanted the the cards on mobile to be two columns to reduce the scrolling. Especially the list of maintainers only really seems to be growing 😅.

Is there perhaps anything you can do to make the two column layout work on mobile?

@TijnR
Copy link
Contributor Author

TijnR commented Jul 22, 2025

@SeanCassiere for sure!

This also looks oke.

image

@SeanCassiere SeanCassiere merged commit e89e922 into TanStack:main Jul 22, 2025
6 checks passed
@SeanCassiere
Copy link
Member

@TijnR thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants