SFINAE-friendly and_then and map
#101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess. This incidentally simplifies the preprocessor stuff, by making these codepaths look the same in both C++11 and C++14. The old code had the weird effect that the C++11 codepath was slightly *more* SFINAE-friendly than the C++14 codepath. This patch doesn't actually make and_then/map/transform/map_error/or_else be SFINAE-friendly. But it lays the groundwork for adding further constraints to the `enable_if` stuff in `and_then_impl` etc., which could make these functions fully SFINAE-friendly without needing to touch the non-`_impl` versions again.
This mainly just swaps two big blocks of code. But it also adds `detail::` in front of every call to `foo_impl`; and it renames `expected_map_impl` to simply `map_impl` because that seems more consistent with the rest of the names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll do
map_errorandor_elsealso; just poking the CI.This depends on (i.e., is a superset of) #99.