Fix noexcept specifier expressions for move operations #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T being void should not prevent the move constructor from being declared noexcept.
T being void should not prevent the move assignment operator from being declared noexcept.
The move constructor should not be declared noexcept if E is not nothrow-move-constructible.
The move assignment operator should not be declared noexcept if E is not nothrow-move-constructible or is not nothrow-move-assignable.
Was not applied to the change made in commit 96d547c
Remove noexcept(false) specifier from move assignment operator. This is how the other can-throw-move test classes are defined. And a non-noexcept move assignment operator is not required for the current tests.
|
The "tweak test class" commit was added with the hope of getting CI to succeed. However the Visual Studio 2015 build still fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the noexcept specifier expressions for the move constructor and the move assignment operator.
For the move constructor, version P0323R10 of the proposal has the following remark:
The expression inside noexcept is equivalent to:
The fix is separated into two commits, the first adds the or-T-is-void part, and the second adds the requirement on E. Test code is included to show the effects of the changes.
For the move assignment operator, the proposal has the following remark:
The expression inside noexcept is equivalent to: is_nothrow_move_assignable_v is true and is_nothrow_move_constructible_v is true.
The fix assumes that the above remark is in error, and that it should be:
The expression inside noexcept is equivalent to:
Again the fix is separated into two commits and includes test code.