-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Use Core I18n to format plurals #12488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Isira-Seneviratne
wants to merge
9
commits into
TeamNewPipe:dev
Choose a base branch
from
Isira-Seneviratne:Core-i18n
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values-ar-rLY/strings.xml # app/src/main/res/values-ar/strings.xml # app/src/main/res/values-be/strings.xml # app/src/main/res/values-ber/strings.xml # app/src/main/res/values-bg/strings.xml # app/src/main/res/values-bn/strings.xml # app/src/main/res/values-ckb/strings.xml # app/src/main/res/values-cs/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-el/strings.xml # app/src/main/res/values-eo/strings.xml # app/src/main/res/values-et/strings.xml # app/src/main/res/values-fa/strings.xml # app/src/main/res/values-fi/strings.xml # app/src/main/res/values-gl/strings.xml # app/src/main/res/values-he/strings.xml # app/src/main/res/values-hi/strings.xml # app/src/main/res/values-hu/strings.xml # app/src/main/res/values-is/strings.xml # app/src/main/res/values-ko/strings.xml # app/src/main/res/values-ku/strings.xml # app/src/main/res/values-lt/strings.xml # app/src/main/res/values-mk/strings.xml # app/src/main/res/values-ms/strings.xml # app/src/main/res/values-ne/strings.xml # app/src/main/res/values-nl-rBE/strings.xml # app/src/main/res/values-or/strings.xml # app/src/main/res/values-pa/strings.xml # app/src/main/res/values-sat/strings.xml # app/src/main/res/values-sv/strings.xml # app/src/main/res/values-te/strings.xml # app/src/main/res/values-th/strings.xml # app/src/main/res/values-ur/strings.xml # app/src/main/res/values-zh-rCN/strings.xml
# Conflicts: # app/src/main/res/values-da/strings.xml
59f8896
to
96b8120
Compare
I don't understand, why did you remove a lot of translated plurals? Also, what's the problem with the current code? |
Those were removed because the original plurals were no longer being used. I could re-add them in the new string resources. There's nothing wrong with the existing code, but it's recommended to use MessageFormat (which the library backports) instead of plurals. |
d44f1ba
to
b6c8276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
codequality
Improvements to the codebase to improve the code quality
localisation / translation
Everything that has to do with translations or Weblate
size/giant
PRs with more than 750 changed lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
MessageFormat
. For more information, see here.Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence