Skip to content

Reserve a Java 9 module name #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reserve a Java 9 module name #51

wants to merge 1 commit into from

Conversation

ljacomet
Copy link
Member

@ljacomet ljacomet commented Oct 9, 2017

No description provided.

@chrisdennis chrisdennis self-requested a review October 9, 2017 13:20
chrisdennis
chrisdennis approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@chrisdennis chrisdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.. would be good to get some small consensus group together on this... and to make sure our module naming is consistent, particularly that we have approval on all module naming in a consistent style before merging any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisdennis chrisdennis chrisdennis approved these changes

+1 more reviewer

@maheshwarigagan maheshwarigagan maheshwarigagan approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ljacomet @chrisdennis @maheshwarigagan