Feature/ifconfig helpers #383
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new validation wrapper to guard against problematic ifconfig values. This also allows us to quickly make all conditionally masked sections visible and play with that logic quickly in a global fashion. This basically adds an early warning mechanism for config values that are no longer valid, misspellings, etc. This is a bit of a hack. The process_ifconfig_nodes in sphinx actually builds a local namespace for evaluating the Python given in the directive. As such only builtin functions are carried over. This means to get anything into that context we need to taint the global builtins definitions. This is fine so long as we don't collide with anything. Signed-off-by: Randolph Sapp <[email protected]>
Use the new key_within helper and add a buggy platform entry to see if it catches it. Signed-off-by: Randolph Sapp <[email protected]>
github-actions
bot
assigned
devarsht,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new validation wrapper to guard against problematic ifconfig
values. This also allows us to quickly make all conditionally masked
sections visible and play with that logic quickly in a global fashion.
This basically adds an early warning mechanism for config values that
are no longer valid, misspellings, etc.
This is a bit of a hack. The process_ifconfig_nodes in sphinx actually
builds a local namespace for evaluating the Python given in the
directive. As such only builtin functions are carried over.
This means to get anything into that context we need to taint the global
builtins definitions. This is fine so long as we don't collide with
anything.