feat(linux): wave5: Add FFMPEG Encode commands #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-brnich
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
|
Please address vale comments. rstcheck and check-files can be ignored here. |
b-brnich
force-pushed
the
ffmpeg-updates
branch
from
12d2ddc to
03dc520
Compare
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
b-brnich
force-pushed
the
ffmpeg-updates
branch
from
03dc520 to
35b9f58
Compare
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
b-brnich
force-pushed
the
ffmpeg-updates
branch
from
35b9f58 to
28b8ab0
Compare
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
|
There are still valid vale warnings about passive voice here. I'd prefer if you also apply it's suggested wording, where it makes sense. |
Wave5 driver has been updated to make it operable with FFMPEG. Update documentation with relevant commands to expose this feature to customers. Signed-off-by: Brandon Brnich <[email protected]>
b-brnich
force-pushed
the
ffmpeg-updates
branch
from
28b8ab0 to
f8a61ad
Compare
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
|
@StaticRocket updated PR to remove all the passive voice warnings and updated grammar where appropriate. Vale is happy now |
|
@b-brnich there are still 5 valid warnings. FYI, you don't have to read the log file directly. Vale does inline comments in the diff view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave5 driver has been updated to make it operable with FFMPEG. Update documentation with relevant commands to expose this feature to customers.