Rename test to avoid name duplication #6033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to duplicate names, one of the tests wasn't run.
|
The CI tests failed on Windows with Python 3.13 with: which is an error I see in at least another workflow run totally unrelated to this PR. |
|
That failing test has been very flaky in CI recently - my second attempt to fix this in PR #6032 |
I see! Thanks for chiming in, I was confused for a bit. |
willmcgugan
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to duplicate names, one of the tests wasn't run. I didn't add that to the changelog.
Please review the following checklist.