Skip to content

fix: correct treap split() comparison to match docstring behavior #14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 4 commits into from
Sep 11, 2026
Merged

fix: correct treap split() comparison to match docstring behavior #14762

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b468e5
fix: correct treap split() to match docstring for equal values (#7854)
maitriupadhyay03-cell Jun 6, 2026
48e35c8
Fix typo in Treap node docstringfix: remove accidental typo in Node c…
maitriupadhyay03-cell Jun 6, 2026
78817c4
Merge branch 'TheAlgorithms:master' into master
maitriupadhyay03-cell Jun 21, 2026
e9d86f1
Fix erase logic in treap.py
cclauss Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data_structures/binary_tree/treap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def split(root: Node | None, value: int) -> tuple[Node | None, Node | None]:
"""
if root is None or root.value is None: # None tree is split into 2 Nones
return None, None
elif value < root.value:
elif value <= root.value:
"""
Right tree's root will be current node.
Now we split(with the same value) current node's left son
Expand Down Expand Up @@ -101,8 +101,8 @@ def erase(root: Node | None, value: int) -> Node | None:
Split all nodes with values greater into right.
Merge left, right
"""
left, right = split(root, value - 1)
_, right = split(right, value)
left, right = split(root, value)
_, right = split(right, value + 1)
return merge(left, right)


Expand Down
Loading