Better Japanese post-processing #570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
TheJoeFin
commented
Nov 10, 2025
TheJoeFin
commented
- Add more testing
- Add better handling of spaces
Enhanced OCR framework to support Japanese text processing. Introduced `PostOcrUtilities` for modular post-OCR handling. Added `ja-word-borders.json` for test data and updated `OcrJapaneseImage` test to use new utilities. Updated `Tests.csproj` to include the JSON file. Refactored to enable language-specific OCR logic.
Improved Japanese text processing and OCR handling, including: - Fixed typos in Japanese test strings for accuracy. - Implemented `GetTextFromJaWordBorders` for line grouping. - Added `ProcessLineToString` for furigana and main text formatting. - Refactored sorting logic with LINQ for modularity. - Enhanced post-processing to merge single-character lines. Added a new Bash command in `settings.local.json` to run `dotnet test` with detailed logging and filtering.
Updated `multiLineInput` in `StringMethodTests.cs` to test edge cases with trailing spaces and adjusted an `[InlineData]` test case. Added `GetTextFromOcrResult` to `PostOcrUtilities.cs` for processing OCR results into `WordBorderInfo` objects, leveraging existing logic in `GetTextFromWordBorderInfo`.
TheJoeFin
added
enhancement
Reversed space-joining condition in OcrUtilities to adjust text processing logic. Removed unused Windows.Media.Ocr namespace from OcrTests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.