Shafix #4
Open
Shafix #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2021 22:17
Added parameter validation to Path parameter Updated help to include parameter content Fixed parameter bug in help text examples
Added ValidateScript to Path parameter to ensure the value is a directory and set the path default to the current path Set the Filter parameter value for the enumeration of the files (it was set to always check all files) Added AlgorithmName parameter to allow the algorithm to be specified Added example to show the default path and how to use the MaxFileSize, AlgorithmName, and TestPartialHas parameters Set positional parameter values on Path and Filter
added 3 commits
January 25, 2021 00:25
updated Notes section Set Path param to accept an array of files
|
I have resolved the conflicts from previous changes and I believe it is ready for merge. Please let me know if you would like to discuss these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: I apologize for the formatting changes. My VSCode defaults are different than yours so when I saved the files the braces and such moved around.
Second: the comparison for these files is messed up. I didn't make that many changes to the functions. Please read the .NOTES section of the help files to see what was changed.
Third: I love what you have done with this function and the detailed explanation on your blog. Thanks.