Conversation
Collaborator
Author
|
Warning @TomDotBat likes men |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
justinkluever
left a comment
justinkluever
left a comment
Collaborator
There was a problem hiding this comment.
Code looks fine and it works, i recommend making the variables local though, as it seems like it still improves the performance a bit on my end.
(i always test with fps_max 999 and without vsync to see minor stutters or bottlenecks)
justinkluever
requested changes
Jul 12, 2025
justinkluever
left a comment
justinkluever
left a comment
Collaborator
There was a problem hiding this comment.
After that i would approve it i think
justinkluever
approved these changes
Jul 12, 2025
justinkluever
left a comment
justinkluever
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
you will probably still be prevented by the linting bot tho
idk how strict tom is about that
Owner
yeah fix the linting pls |
|
this pr is fire |
Collaborator
Author
thanks man i put my heart and soul into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read the title