Core/AreaTriggers: Handle exit areatrigger on player map change #31077
+86
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Jun 15, 2025
| @@ -1418,6 +1418,9 @@ bool Player::TeleportTo(TeleportLocation const& teleportLocation, TeleportToOpti | |||
| // remove all areatriggers entities | |||
| RemoveAllAreaTriggers(); | |||
|
|
|||
| // exit all areatriggers the unit is in | |||
| ExitAllAreaTriggers(); | |||
There was a problem hiding this comment.
including those that are attached to the player teleporting? what if there's no map change aura interrupt flag for an aura auratrigger
There was a problem hiding this comment.
thats pretty much the reason of this pr. Currently you can enter an areatrigger (e.g. Telash Frostbomb) and teleport to barrens and still keep the debuff. This PR prevents that
There was a problem hiding this comment.
my worry is that there might be aura areatriggers that aren't supposed to be removed from the unit (in this case a player) regardless of map change, unless there's proof that they're always removed and re-cast when they get into the new map if they happen to be the caster
Shauren
reviewed
Jun 19, 2025
Shauren
requested changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests performed:
(Does it build, tested in-game, etc.)
tested ingame using Telash Greywing Frostbomb (spell 387149) in Azure Vault and then teleporting to barrens