-
Notifications
You must be signed in to change notification settings - Fork 16
compiler/ cleanup #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ssoelvsten
wants to merge
30
commits into
TroupeLang:dev-integrity
Choose a base branch
from
ssoelvsten:fork/dev/compiler-cleanup
base: dev-integrity
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
compiler/ cleanup #79
ssoelvsten
wants to merge
30
commits into
TroupeLang:dev-integrity
from
ssoelvsten:fork/dev/compiler-cleanup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29cb8c4 to
7629c96
Compare
43fc993 to
cd5e0b8
Compare
22d5b5e to
ae3b361
Compare
This brings the name closer to the actual meaning of this construction.
This way, is is less likely one by accident exports the wrong function under a different name
This frees '-l' up to be used for a '--link' later
These are (a) only used by the runtime and/or (b) only used seldomly. Hence, we may as well open up for these to be used for something different, e.g. modules
This is the only place it is used. Furthermore, having it defined in IR removes it from the context of having to make it be valid JSON; anything that is deemed 'prettier' might by accident be "re"used
There seems to be some unecessary complexity as a leftover of previous designs?
cd5e0b8 to
f29f96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✨ code quality
Uncle Bob would be proud
📁 ./compiler
Changes, errors, and additions for the compiler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preliminary clean up as I'm looking at adding nomadic modules throughout the compiler pipeline ( #66 ).