Skip to content

Conversation

IsaiMaganTNO
Copy link
Contributor

Related issues

Closes #1245

Hi all, this is the PR for implementing the contribution from the TLC data group into the documentation. I have attempted to pass tests using LiveServer (as was recommended in the contribution documentation specifically for building documentation locally) but I am not sure if I worked with this correctly.. It provided errors for other markdown files but not this one. I will create a draft pull request, please let me know if there is anyway I can properly check the tests using LiveServer or another package.

Checklist

  • I am following the contributing guidelines

  • Tests are passing

  • Lint workflow is passing

  • Docs were updated and workflow is passing

@IsaiMaganTNO IsaiMaganTNO requested review from clizbe and gnawin June 4, 2025 15:24
@gnawin
Copy link
Member

gnawin commented Jun 5, 2025

Hi @IsaiMaganTNO, thanks a lot. I have yet checked the details, but one of the CI/CD workflows is failing, probably because you have not configured pre-commit locally. I can help with that if you want :). Let me know.

@IsaiMaganTNO
Copy link
Contributor Author

Hi @IsaiMaganTNO, thanks a lot. I have yet checked the details, but one of the CI/CD workflows is failing, probably because you have not configured pre-commit locally. I can help with that if you want :). Let me know.

Hi @gnawin that would be great! I could use some help so I will contact you and maybe we can sit together some time next week to see how I can configure it properly. Thanks!


first(df_assets, 40)
CSV.write("asset.csv", df_assets)
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clizbe
Copy link
Member

clizbe commented Sep 25, 2025

@IsaiMaganTNO What's the status on this one. Do you need some help getting it merged?

@IsaiMaganTNO
Copy link
Contributor Author

@IsaiMaganTNO What's the status on this one. Do you need some help getting it merged?

I am currently using it as inspiration for the new and improved workflow tutorial for the TLC. I will keep an eye on it, let's decide what to do with it once that one has been finished (hopefully by end of this week!) if that's OK with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Including the contribution of the TLC Data team

4 participants