Skip to content

Conversation

SharkPool-SP
Copy link
Collaborator

resolves:
#2000

Made it a new block and hid the old one

@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Apr 9, 2025
@SharkPool-SP
Copy link
Collaborator Author

!format

@SharkPool-SP SharkPool-SP changed the title Lily/LooksPlus.js -- make the 'set costume content' block wait for the content to finish loading Lily/LooksPlus -- 'set costume content' block must wait for content to finish loading Apr 9, 2025
@SharkPool-SP
Copy link
Collaborator Author

!format

Copy link

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

Copy link

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@GarboMuffin
Copy link
Member

can you think of any case where old behavior would be wanted to justify just leaving both of these blocks in there?

@yuri-kiss

This comment was marked as abuse.

@SharkPool-SP
Copy link
Collaborator Author

the old block should still be hidden though. Its going to have a menu with no utility as bitmap support isnt gonna be added (with skins existing)

there could be a block argument added for wether to wait or not in the new block

Copy link
Contributor

@Brackets-Coder Brackets-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, looks alright I guess unless there's something I'm missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: change existing extension Pull requests that change an existing extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants