Make problem as part of the state of ParamSpaceSGD instead of an argument of estimate_gradient!
#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-Portal
changed the title
problem as part of the state instead of an argument of estimate_gradient!problem as part of the state instead of an argument of estimate_gradient!
Red-Portal
changed the title
problem as part of the state instead of an argument of estimate_gradient!problem as part of the state of ParamSpaceSGD instead of an argument of estimate_gradient!
yebai
approved these changes
Jul 30, 2025
|
I'm not sure why this simplifies #180, but it seems like a minor and harmless change, so I'm happy to approve. |
Red-Portal
force-pushed
the
problem_part_of_state
branch
from
8692bc6 to
20eeb6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how
ParamSpaceSGDinteracts with the target problem. Instead of receiving the problemprobas an argument ofestimate_gradient!, it now stores it in the state when callinginit. The main advantage of this choice is that, whenever some modifications/preparations need to be done toprob, it only needs to be done once ininit. This is necessary for simplifying #180 .