-
Notifications
You must be signed in to change notification settings - Fork 5
fix: APPS_3447 override image style media gallery #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
@farosFreed Can we do this change on the template instead of in the component library, or we can create a prop instead of using |
@pghorpade Yeah - If we do a prop then I will need to make changes to flexible page blocks to pass the correct prop to the carousels based on the theme and we will likely need to make some page level ftva changes to implement the prop - it will not be a small localized change. But maybe it's better to make it a prop now rather than later when there are even more rules. It would be quickest and easiest to just move the code (including the I'm still waiting for UX approval on this but let me know which approach you're leaning toward. |
Another option to prop is to inject/provide in Vue, so we don't have to do prop drilling if the child component where the prop is used is further down the hierarchy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# [@ucla-library-monorepo/ucla-library-website-components-v1.34.2](https://github.com/UCLALibrary/ucla-library-website-components/compare/@ucla-library-monorepo/ucla-library-website-components-v1.34.1...@ucla-library-monorepo/ucla-library-website-components-v1.34.2) (2025-10-09) ### Bug Fixes * APPS_3447 override image style media gallery ([#829](#829)) ([59dd322](59dd322))
🎉 This PR is included in version @ucla-library-monorepo/ucla-library-website-components-v1.34.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Connected to APPS-3447
Component Edited: FTVA MediaGallery.vue styles
Notes:
Checklist:
library-website-nuxt dev server