Skip to content

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 3, 2025

Connected to APPS-3475

Component Updated: ImageSlider.vue

Stories Updated: ~/stories/ImageSlider.stories.js

Notes:

  • Added images with different aspect ratios to story data
  • Added dynamic aspect ratio calculations based on image height and width

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • [ ] I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed self-assigned this Oct 3, 2025
@farosFreed farosFreed added the feature feature label Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Oct 3, 2025

@github-actions github-actions bot temporarily deployed to storybook--pull_request-833 October 3, 2025 22:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-833 October 9, 2025 17:21 Inactive
@farosFreed farosFreed marked this pull request as ready for review October 9, 2025 17:26
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit f68f5f4 into main Oct 9, 2025
18 checks passed
@pghorpade pghorpade deleted the APPS-3475_Imageslider_enhancements branch October 9, 2025 21:48
pghorpade pushed a commit that referenced this pull request Oct 9, 2025
@pghorpade
Copy link
Contributor

🎉 This PR is included in version @ucla-library-monorepo/ucla-library-website-components-v1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants