fix(builder): JSDoc: avoid errors when symbol has no events#1329
Open
maxreichmann wants to merge 2 commits intomainfrom
Open
fix(builder): JSDoc: avoid errors when symbol has no events#1329maxreichmann wants to merge 2 commits intomainfrom
maxreichmann wants to merge 2 commits intomainfrom
Conversation
maxreichmann
requested review from
RandomByte,
codeworrior,
d3xter666 and
flovogt
maxreichmann
force-pushed
the
fix/jsdoc/AvoidErrorForSymbolWithNoEvents
branch
from
858a8d0 to
c3b47d0
Compare
RandomByte
reviewed
Mar 20, 2026
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
maxreichmann
force-pushed
the
fix/jsdoc/AvoidErrorForSymbolWithNoEvents
branch
from
d84dc84 to
6afbf3a
Compare
Member
|
While I like the idea of unit tests in general, I think it is a bad idea to have this test only in the @ui5/cli. The transformApiJson is mainly developed in openui5/lib/jsdoc. If the test does not exist there, risk is high that the next sync from openui5 to @ui5/cli gets unnecessarily difficult. I would in general prefer to make openui5/lib/jsdoc the single source of truth and the copy here just a copy. There is even a test for the transformer, but it's located in a different place (for historical reasons, I guess)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug which initially has been fixed in v4 (SAP/ui5-builder#1162) but not upported to v5 yet. This fix also resolves the error occurrence found when running
ui5 build jsdocin the UI5/sample-app.This will add a unit test for transformApiJson.js covering this scenario.