Skip to content

ci: Enable Node's strict engine check on CI#263

Open
d3xter666 wants to merge 1 commit intomainfrom
refactor-engine-strict
Open

ci: Enable Node's strict engine check on CI#263
d3xter666 wants to merge 1 commit intomainfrom
refactor-engine-strict

Conversation

@d3xter666
Copy link
Member

No description provided.

@d3xter666 d3xter666 requested a review from a team February 27, 2026 13:06
@d3xter666 d3xter666 marked this pull request as draft February 27, 2026 13:12
@flovogt flovogt force-pushed the refactor-engine-strict branch from 63fb5c1 to 2da6713 Compare February 27, 2026 13:39
@flovogt flovogt marked this pull request as ready for review February 27, 2026 13:40
@flovogt flovogt force-pushed the refactor-engine-strict branch from 2da6713 to 03da0d7 Compare February 27, 2026 13:52
@maxreichmann
Copy link
Member

--engine-strict still doesn't work here (as described in #99 (comment)). We would have to bump the package's node version first.

@matz3
Copy link
Member

matz3 commented Mar 3, 2026

I would propose looking into tools like check-engine-light which does not check devDependencies by default. Of course, we need to be able to run our tests with the minimum Node version, but in this case, it looks to me that the relevant dev dependency (MCP inspector) is only used for manual testing, right?
I would disagree with bumping the Node requirements for our consumers, just because we use a dependency for manual testing which only runs on higher versions.

But those are just my 2 cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants