[FIX] sap.m.IllustrationPool: gracefully remove DOM pool assets #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hello @dfenerski , Thank you for sharing your enhancement proposal. I've created an internal incident DINC0582971. The code owner will take a look on this PR. Best Regards, |
Contributor
|
Hi @dfenerski . The PR was successfully merged in UI5. |
openui5bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
Assume for whatever reason execution reaches line 464 Execution of _removeAssetFromDOMPool starts In the function body, there are 2 checks which assert: 3.1. oDOMPool (a "static" DOM element) exists 3.2. oAssetDOM (the thing we presumably no longer need and want to remove) exists If for whatever reason any of these do not exist, the _removeAssetFromDOMPool will silently do nothing (it will leave aSymbolsInDOM intact) Execution will return to line 461 to an unmodified array, freezing the application in an infinite loop. Some semantics In my case, oAssetDOM was being removed dynamically, by some other application code. Leaving the question whether this element should be removed by some other application code aside, it seems to me the symbol removal should not be tied to the DOM element removal, unless I have missed some other dependency. In any case, "get your app frozen if you remove the wrong DOM element" feels weird so I decided to check for second opinion by opening this PR. Closes #4309 Change-Id: Ia53516b33cfd078e33d53022e808925fe0ce8fbb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup
_removeAssetFromDOMPoolstarts3.1.
oDOMPool(a "static" DOM element) exists3.2.
oAssetDOM(the thing we presumably no longer need and want to remove) exists_removeAssetFromDOMPoolwill silently do nothing (it will leaveaSymbolsInDOMintact)Some semantics
In my case,
oAssetDOMwas being removed dynamically, by some other application code.Leaving the question whether this element should be removed by some other application code aside, it seems to me the symbol removal should not be tied to the DOM element removal, unless I have missed some other dependency.
In any case, "get your app frozen if you remove the wrong DOM element" feels weird so I decided to check for second opinion by opening this PR.