Skip to content

feat(ui5-select): support associated labels with 'for' attribute #11926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

feat(ui5-select): support associated labels with 'for' attribute #11926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbec3ce
feat(ui5-select): support associated labels with 'for' attribute
NakataCode Jul 16, 2025
b639cd7
Merge branch 'main' into select-label-attr
NakataCode Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/main/cypress/specs/Select.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,28 @@ describe("Select - Accessibility", () => {
cy.get("@select")
.should("have.attr", "title", "Go home");
});

it("should announce the associated label when Select is focused", () => {
cy.mount(
<>
<label for="sel">Should be the aria-label</label>
<Select id="sel">
<Option value="option1">Option 1</Option>
<Option value="option2">Option 2</Option>
<Option value="option3">Option 3</Option>
</Select>
</>
);

cy.get('label[for="sel"]')
.invoke('text')
.then((labelText) => {
cy.get("[ui5-select]")
.shadow()
.find(".ui5-select-label-root")
.should("have.attr", "aria-label", labelText);
});
});
});

describe("Select - Popover", () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/Select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
isTabPrevious,
} from "@ui5/webcomponents-base/dist/Keys.js";
import announce from "@ui5/webcomponents-base/dist/util/InvisibleMessage.js";
import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import { getEffectiveAriaLabelText, getAssociatedLabelForTexts } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
import "@ui5/webcomponents-icons/dist/error.js";
import "@ui5/webcomponents-icons/dist/alert.js";
Expand Down Expand Up @@ -966,7 +966,7 @@ class Select extends UI5Element implements IFormInputElement {
}

get ariaLabelText() {
return getEffectiveAriaLabelText(this);
return getEffectiveAriaLabelText(this) || getAssociatedLabelForTexts(this);
}

get shouldDisplayDefaultValueStateMessage() {
Expand Down
Loading