Skip to content

Conversation

dayantur
Copy link

@dayantur dayantur commented Sep 30, 2025

This PR addresses a bug in the range constraint for bldgh in site.py.

Main changes

  • bldgh Pydantic Field set to be ge=0 in site.py

@dayantur dayantur temporarily deployed to github-pages-preview September 30, 2025 09:27 — with GitHub Actions Inactive
@dayantur dayantur requested a review from sunt05 September 30, 2025 09:27
Copy link

🔍 Schema Preview Deployed

Preview URLs:

Production URLs (unchanged):


⚠️ Important: Preview schemas are in a subdirectory and do not affect production. The preview pages include warning banners to prevent accidental use in production configs.

@sunt05
Copy link

sunt05 commented Sep 30, 2025

No – the counter issue relates to the grid ID, not the building height constraint. The user's concern, for example, is that the 5 in sites.5 should match the grid ID, not the internal Python counter (which starts from 0).

@suegrimmond
Copy link

Note Grid ID - can be very different from numerical order -

@dayantur
Copy link
Author

@sunt05 @suegrimmond sorry for the mistake - I will open a different PR for that issue :) and edit the description of this PR

@dayantur dayantur changed the title Yaml validator counter issue Range of bldgh in Pydantic model Sep 30, 2025
@dayantur dayantur changed the title Range of bldgh in Pydantic model Fix range of bldgh in Pydantic model Sep 30, 2025
@sunt05 sunt05 merged commit 441420f into master Oct 14, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants