inherit environment variables that enable ABI3#1462
Merged
jswhit merged 1 commit intoUnidata:masterfrom Jan 6, 2026
Merged
Conversation
Collaborator
Author
|
Seems to do the trick!: See https://github.com/Unidata/netcdf4-python/actions/runs/20720797112/job/59485979149?pr=1462 |
Collaborator
|
Thanks @ocefpaf ! I've uploaded the manylinux abi3 wheels - wonder if I need to delete the existing cp311 wheels? |
Collaborator
Author
No idea what the install order is. I would delete to make it easy to debug possible issues. There are so many variables already, we do not want to ask users if they have the ABI3 or the non-ABI3. |
Collaborator
Author
|
PS: A quick test show that on py311, where the ABI3 conflicts with the non-ABI3 wheel, the non-ABI3 will be installabled: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1461
We will need a post release after this one is merged.