Skip to content

Add APB verification components #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: vc_standard
Choose a base branch
from
Open

Add APB verification components #1070

wants to merge 22 commits into from

Conversation

c-thaler
Copy link

I added APB master and slave VCs. The APB master is based on a VC that I used in a few of my designs.

@LarsAsplund
Copy link
Collaborator

Thanks @c-thaler, I will look into it! Please have a look at the VC standard being discussed #1017

@c-thaler
Copy link
Author

Thanks. I had a look at it and I will start with implementing Rule 13 (single generic).

@c-thaler
Copy link
Author

c-thaler commented Nov 1, 2024

I've also implemented rules 10/15 (locking test runner cleanup gate while busy) and 14 (sync interface).

@LarsAsplund
Copy link
Collaborator

Please rebase on the vc_standard branch and you will get rid of the failing tests that have noting to do with this PR. You will also have access to the functions and types mentioned in the rules (located in vc_pkg.vhd

@c-thaler c-thaler changed the base branch from master to vc_standard November 4, 2024 21:30
@c-thaler
Copy link
Author

c-thaler commented Nov 9, 2024

@LarsAsplund The idea is to use create_std_cfg within the constructor of my VC, right? That also means that the logger parameter can be removed from my VC's constructor?

c-thaler added 20 commits January 30, 2025 00:34
@c-thaler
initial checkin of APB master and slave VC
54c28e8
@c-thaler
set expected word for single write test
24733f6
@c-thaler
implement wait states
cd82e04
@c-thaler
fix trailing whitespace
9768826
@c-thaler
fix another trailing whitespace
64051a7
@c-thaler
use single generic parameter
1e2f86f 
All generics are now integrated into a single parameter of type
apb_master_t.
@c-thaler
reduce to single generic parameter in apb slave
d29dd9f
@c-thaler
use null_actor/null_logger as defaults for master
64e0096
@c-thaler
use null_logger as default for apb slave
51cd953
@c-thaler
let the apb_master ctor be handled by bus_master
dd5143f 
The bus_master implementation will create an actor if null_actor is
given as parameter. So we don't have to do it in apb_master.
@c-thaler
lock test_runner_cleanup entry gate
6ee4d32 
Keep it locked while there is unfinished work to do.
@c-thaler
add support for sync interface
5c764e3
@c-thaler
fix whitespace issues
a321bdf
@c-thaler
rename APB files according to specification
a6b1503
@c-thaler
rename entities according to spec
aba1bca
@c-thaler
implement support for pslverror
2683038 
Major change to support optional pslverror signal of APB3.
@c-thaler
add pslverror test cases and fix issue
baa2a59
@c-thaler
fix instance names
514a7d8
@c-thaler
add id and unexpected message policy parameter
e2e0023 
Implementing rules 5 and 10.
The logger name is set according to the id field.
@c-thaler
Started with switching to std_cfg (WIP)
9d79889
@LarsAsplund
Copy link
Collaborator

I have two projects where this can be useful. I will have it tested there to see if there are issues to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-thaler @LarsAsplund