Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/news.d/1178.bug.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed missing generated seed input to pre_config hook.
3 changes: 3 additions & 0 deletions tests/acceptance/artificial/vhdl/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def pre_config(seed):
print(f"pre_config seed: {seed}")
if not expected_seed:
assert seed != "0123456789abcdef"
assert seed is not None
else:
assert seed == expected_seed

Expand All @@ -190,6 +191,8 @@ def pre_config(seed):
tb.test("test_2").set_generic("expected_seed", "9a292b3679afd081")
tb.test("test_1").set_pre_config(make_pre_config("7ac31eb89c4059f9"))
tb.test("test_2").set_pre_config(make_pre_config("8b1cd665d806e572"))
elif args.seed is None:
tb.set_pre_config(make_pre_config())


def configure_tb_vunit_pkg(vu):
Expand Down
10 changes: 10 additions & 0 deletions tests/acceptance/test_artificial.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ def test_repeated_seed(self):
],
)

def test_generated_seed(self):
self.check(self.artificial_run_vhdl, args=["lib.tb_seed*"])
check_report(
self.report_file,
[
("passed", "lib.tb_seed.test_1"),
("passed", "lib.tb_seed.test_2"),
],
)

def test_not_executing_package_init_on_package_addition(self):
self.check(self.artificial_run_vhdl, args=["lib.tb_vunit_pkg.all"])
check_report(
Expand Down
3 changes: 2 additions & 1 deletion vunit/test/suites.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ def run(self, output_path, read_output):
for name in self._test_cases:
results[name] = FAILED

if not self._config.call_pre_config(output_path, self._simulator_if.output_path, self._seed):
seed = self.get_seed()
if not self._config.call_pre_config(output_path, self._simulator_if.output_path, seed):
return results

# Ensure result file exists
Expand Down
Loading