ci: add GitHub Actions for commitlint and DCO checks #25

zoxilsi · 2025-07-27T06:11:36Z

🎯 Purpose

This PR adds automated commit message validation and DCO (Developer Certificate of Origin) enforcement to ensure code quality and legal compliance for all contributions.

✨ Changes

Commitlint Workflow (.github/workflows/commitlint.yml)
- Enforces Conventional Commits standard using @commitlint/config-conventional
- Validates all commits in pull requests
- Fails if commit messages don't follow proper format (e.g., feat:, fix:, docs:)
DCO Check Workflow (.github/workflows/dco.yml)
- Uses CNCF DCO GitHub Action to verify signed commits
- Ensures every commit has Signed-off-by: line
- Prevents unsigned commits from being merged
Commitlint Configuration (commitlint.config.js)
- Configures allowed commit types and formatting rules
- Sets maximum header length and case requirements

🔧 How It Works

Both workflows trigger automatically on pull requests to master and main branches. They will:

✅ Pass when commits follow standards and are properly signed
❌ Fail when commits violate formatting rules or lack DCO sign-off

📋 Next Steps

After merging, enable these as required status checks in branch protection settings to enforce compliance.

🧪 Testing

These workflows can be tested by creating PRs with both valid and invalid commit messages/signatures.

closes #13

zoxilsi · 2025-07-27T06:13:09Z

@thedevyashsaini @sapatevaibhav . Can you check and review the PR

thedevyashsaini · 2025-07-27T15:43:14Z

.github/workflows/dco.yml

+  pull_request:
+    branches: [ master, main ]


Consider adding a types: filter to the pull_request trigger to avoid unnecessary runs

thedevyashsaini · 2025-07-27T15:45:55Z

.github/workflows/commitlint.yml

+          npm install --save-dev @commitlint/config-conventional @commitlint/cli
+
+      - name: Validate current commit (last commit) with commitlint
+        if: github.event_name == 'push'


block is irrelevant as this workflow is only triggered on pull_request

thedevyashsaini · 2025-07-27T15:46:10Z

.github/workflows/commitlint.yml

+
+      - name: Install dependencies
+        run: |
+          npm install --save-dev @commitlint/config-conventional @commitlint/cli


Install dependencies should use --no-save instead of --save-dev

thedevyashsaini · 2025-07-27T15:46:57Z

commitlint.config.js

+module.exports = {
+  extends: ['@commitlint/config-conventional'],
+  rules: {
+    'type-enum': [
+      2,
+      'always',
+      [
+        'build',
+        'chore',
+        'ci',
+        'docs',
+        'feat',
+        'fix',
+        'perf',
+        'refactor',
+        'revert',
+        'style',
+        'test'
+      ]
+    ],
+    'subject-case': [2, 'never', ['start-case', 'pascal-case', 'upper-case']],
+    'subject-empty': [2, 'never'],
+    'subject-full-stop': [2, 'never', '.'],
+    'header-max-length': [2, 'always', 72]
+  }
+};


add comments for team clarity

Signed-off-by: zoxilsi <[email protected]>

zoxilsi · 2025-07-27T17:20:55Z

@thedevyashsaini Made changes as per your review. Do check it out

thedevyashsaini · 2025-07-27T17:36:10Z

@thedevyashsaini Made changes as per your review. Do check it out

is .github/pull_request_template.md relevant here?

zoxilsi · 2025-07-27T17:43:36Z

NOT directly relevant for the specific review feedback

IS relevant for overall project improvement:

The PR template prevents future issues by ensuring contributors follow DCO requirements
It includes a DCO compliance checklist that enforces the standards you just implemented
It standardizes the contribution process

@thedevyashsaini

zoxilsi · 2025-07-28T11:39:06Z

@thedevyashsaini can you review the pr

zoxilsi · 2025-07-30T09:39:42Z

@sapatevaibhav Review the pr and give me update

thedevyashsaini · 2025-07-31T14:25:15Z

NOT directly relevant for the specific review feedback

IS relevant for overall project improvement:

The PR template prevents future issues by ensuring contributors follow DCO requirements

It includes a DCO compliance checklist that enforces the standards you just implemented

It standardizes the contribution process

@thedevyashsaini

Another PR is opened for the PR #31 template specifically, so remove that part

zoxilsi · 2025-07-31T14:30:14Z

i commited this 3 days ago .
and why you guys are asking me to remove
even though it still relevent
Plz kindly accept it

sapatevaibhav · 2025-08-01T20:12:18Z

and why you guys are asking me to remove

^-^

zoxilsi · 2025-08-01T20:16:54Z

and why you guys are asking me to remove

^-^

@sapatevaibhav what is the issue still its not merged and close the pr or the issue
If there something kindly update to me

sapatevaibhav · 2025-08-01T20:16:54Z

@thedevyashsaini Except PR template is everything ok?

sapatevaibhav · 2025-08-01T20:18:42Z

what is the issue still its not merged and close the pr or the issue

Yes just looking for Mentors confirmation.

thedevyashsaini · 2025-08-02T08:36:16Z

i commited this 3 days ago . and why you guys are asking me to remove even though it still relevent Plz kindly accept it

ur being asked to remove the file cuz u can't just write anything in the description and then change random things - someone else is also working on the PR template thing... if u feel like merging multiple issues, u gotta mention that first so that other people don't waster their time on it.

Just remove that file and the PR is good to go....

thedevyashsaini · 2025-08-02T08:36:23Z

@thedevyashsaini Except PR template is everything ok?

yea

ci: add GitHub Actions for commitlint and DCO checks

d333c6b

sapatevaibhav requested a review from thedevyashsaini July 27, 2025 09:40

thedevyashsaini requested changes Jul 27, 2025

View reviewed changes

feat: enhance DCO workflow and add comprehensive contribution guidelines

3b6d830

Signed-off-by: zoxilsi <[email protected]>

Merge branch 'master' into master

db4c4d3

sapatevaibhav mentioned this pull request Aug 1, 2025

Added files for Pull request template #31

Open

sapatevaibhav added 2 commits August 11, 2025 13:54

Delete .github/pull_request_template.md

1e05af7

Update CONTRIBUTING.md

d4062e1

sapatevaibhav added good first issue Good for newcomers GSSoC'25 GirlScript Summer of Code 2025 level1 labels Aug 11, 2025

sapatevaibhav approved these changes Aug 11, 2025

View reviewed changes

sapatevaibhav merged commit 63c96ba into VaibhavCodeClub:master Aug 11, 2025

ci: add GitHub Actions for commitlint and DCO checks #25

ci: add GitHub Actions for commitlint and DCO checks #25

Uh oh!

Conversation

zoxilsi commented Jul 27, 2025 • edited by sapatevaibhav Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Purpose

✨ Changes

🔧 How It Works

📋 Next Steps

🧪 Testing

Uh oh!

zoxilsi commented Jul 27, 2025

Uh oh!

thedevyashsaini Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

thedevyashsaini Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

thedevyashsaini Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

thedevyashsaini Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

zoxilsi commented Jul 27, 2025

Uh oh!

thedevyashsaini commented Jul 27, 2025

Uh oh!

zoxilsi commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zoxilsi commented Jul 28, 2025

Uh oh!

zoxilsi commented Jul 30, 2025

Uh oh!

thedevyashsaini commented Jul 31, 2025

Uh oh!

zoxilsi commented Jul 31, 2025

Uh oh!

sapatevaibhav commented Aug 1, 2025

Uh oh!

zoxilsi commented Aug 1, 2025

Uh oh!

sapatevaibhav commented Aug 1, 2025

Uh oh!

sapatevaibhav commented Aug 1, 2025

Uh oh!

thedevyashsaini commented Aug 2, 2025

Uh oh!

thedevyashsaini commented Aug 2, 2025

Uh oh!

Uh oh!

zoxilsi commented Jul 27, 2025 •

edited by sapatevaibhav

Loading

zoxilsi commented Jul 27, 2025 •

edited

Loading