Skip to content

ntdll: Don't leak objattr allocation in NtCreateSemaphore. #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proton_8.0
Choose a base branch
from
Open

ntdll: Don't leak objattr allocation in NtCreateSemaphore. #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dlls/ntdll/unix/sync.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,15 @@ NTSTATUS WINAPI NtCreateSemaphore( HANDLE *handle, ACCESS_MASK access, const OBJ

*handle = 0;
if (max <= 0 || initial < 0 || initial > max) return STATUS_INVALID_PARAMETER;
if ((ret = alloc_object_attributes( attr, &objattr, &len ))) return ret;

if (do_fsync())
return fsync_create_semaphore( handle, access, attr, initial, max );

if (do_esync())
return esync_create_semaphore( handle, access, attr, initial, max );

if ((ret = alloc_object_attributes( attr, &objattr, &len ))) return ret;

SERVER_START_REQ( create_semaphore )
{
req->access = access;
Expand Down