Skip to content

Rename modules to knowledge_qa#33

Merged
amrit110 merged 1 commit intomainfrom
rename_to_knowledge_qa
Feb 4, 2026
Merged

Rename modules to knowledge_qa#33
amrit110 merged 1 commit intomainfrom
rename_to_knowledge_qa

Conversation

@amrit110
Copy link
Member

@amrit110 amrit110 commented Feb 4, 2026

  • Renaming the implementation and sub-package to knowledge_qa which is more aligned with the naming convention of the other implementations, i.e. remove "agent"

@amrit110 amrit110 self-assigned this Feb 4, 2026
@amrit110 amrit110 added the refactor Refactor or clean up code structure label Feb 4, 2026
@amrit110 amrit110 requested review from fcogidi and lotif February 4, 2026 19:46
Copy link
Collaborator

@fcogidi fcogidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple Find and Replace. I didn't confirm all old names were changed in the code.

@fcogidi fcogidi requested a review from Copilot February 4, 2026 20:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the knowledge_agent module to knowledge_qa to better align with naming conventions used across other implementations in the codebase.

Changes:

  • Updated import statements from aieng.agent_evals.knowledge_agent to aieng.agent_evals.knowledge_qa across all files
  • Changed CLI script entry point from knowledge-agent to knowledge-qa in pyproject.toml
  • Updated app_name parameter values from "knowledge_agent" to "knowledge_qa" in the agent implementation

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
implementations/knowledge_qa/gradio_app.py Updated import path and command example in docstring
implementations/knowledge_qa/README.md Updated import paths and command examples in documentation
implementations/knowledge_qa/03_multi_turn.ipynb Updated import path in notebook
implementations/knowledge_qa/02_agent_basics.ipynb Updated import paths in notebook code cell
implementations/knowledge_qa/01_grounding_basics.ipynb Updated import path in notebook code cell
aieng-eval-agents/tests/aieng/agent_evals/knowledge_qa/test_evaluation.py Updated import paths and patch decorators in test file
aieng-eval-agents/tests/aieng/agent_evals/knowledge_qa/test_agent.py Updated import paths and patch decorators in test file
aieng-eval-agents/pyproject.toml Updated CLI script entry point name
aieng-eval-agents/aieng/agent_evals/knowledge_qa/evaluation.py Updated import path in docstring example
aieng-eval-agents/aieng/agent_evals/knowledge_qa/agent.py Updated import path in docstring example and app_name parameters
aieng-eval-agents/aieng/agent_evals/knowledge_qa/init.py Updated import path in docstring example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amrit110 amrit110 merged commit f5bb738 into main Feb 4, 2026
3 checks passed
@amrit110 amrit110 deleted the rename_to_knowledge_qa branch February 4, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor or clean up code structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants