Conversation
fcogidi
approved these changes
Feb 4, 2026
Collaborator
fcogidi
left a comment
There was a problem hiding this comment.
Looks like a simple Find and Replace. I didn't confirm all old names were changed in the code.
There was a problem hiding this comment.
Pull request overview
This PR renames the knowledge_agent module to knowledge_qa to better align with naming conventions used across other implementations in the codebase.
Changes:
- Updated import statements from
aieng.agent_evals.knowledge_agenttoaieng.agent_evals.knowledge_qaacross all files - Changed CLI script entry point from
knowledge-agenttoknowledge-qain pyproject.toml - Updated
app_nameparameter values from"knowledge_agent"to"knowledge_qa"in the agent implementation
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| implementations/knowledge_qa/gradio_app.py | Updated import path and command example in docstring |
| implementations/knowledge_qa/README.md | Updated import paths and command examples in documentation |
| implementations/knowledge_qa/03_multi_turn.ipynb | Updated import path in notebook |
| implementations/knowledge_qa/02_agent_basics.ipynb | Updated import paths in notebook code cell |
| implementations/knowledge_qa/01_grounding_basics.ipynb | Updated import path in notebook code cell |
| aieng-eval-agents/tests/aieng/agent_evals/knowledge_qa/test_evaluation.py | Updated import paths and patch decorators in test file |
| aieng-eval-agents/tests/aieng/agent_evals/knowledge_qa/test_agent.py | Updated import paths and patch decorators in test file |
| aieng-eval-agents/pyproject.toml | Updated CLI script entry point name |
| aieng-eval-agents/aieng/agent_evals/knowledge_qa/evaluation.py | Updated import path in docstring example |
| aieng-eval-agents/aieng/agent_evals/knowledge_qa/agent.py | Updated import path in docstring example and app_name parameters |
| aieng-eval-agents/aieng/agent_evals/knowledge_qa/init.py | Updated import path in docstring example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knowledge_qawhich is more aligned with the naming convention of the other implementations, i.e. remove "agent"