Skip to content

ci: fix DeprecationWarnings / strict job #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ci: fix DeprecationWarnings / strict job #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fa41b3
Travis: run job with strict DeprecationWarnings
blueyed Jul 19, 2019
2c81737
TEMP: single job
blueyed Jul 19, 2019
23449bf
fixup! TEMP: single job
blueyed Jul 19, 2019
02333f2
tests: fix DeprecationWarnings
blueyed Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,13 @@ jobs:
include:
- name: Python 3.7 (integration)
python: "3.7"
env: TOXENV=py37-cov
env:
- TOXENV=py37-cov
# Fail on (internal) deprecation warnings.
- PYTEST_ADDOPTS="$PYTEST_ADDOPTS -Werror::DeprecationWarning -Wonce::DeprecationWarning:.*[/\\](_bundles|site-packages)[/\\]"
git:
# Check out vital.vim for test_cli_vital.
submodules: true
- name: Python 2.7
python: "2.7"
env: TOXENV=py27-cov
- name: Python 3.6
python: "3.6"
env: TOXENV=py36-cov
- name: Python 3.5
python: "3.5"
env: TOXENV=py35-cov
- name: Python 3.4
python: "3.4"
env: TOXENV=py34-cov

install:
- pip install tox
Expand Down
11 changes: 1 addition & 10 deletions test/acceptance/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,6 @@


class TestCLI(unittest.TestCase):
def assertRegex(self, string, pattern):
assertRegexpMatches = getattr(self, 'assertRegexpMatches', None)
if assertRegexpMatches:
assertRegexpMatches(string, pattern)
return

super(TestCLI, self).assertRegex(string, pattern)


def assertReturnedStdoutEqual(self, expected_stdout, args):
got_stdout = '(no stdout)'
cmd = [sys.executable, '-m', 'vint'] + args
Expand Down Expand Up @@ -139,7 +130,7 @@ def test_exec_vint_with_color_flag(self):

got_output = context_manager.exception.output

expected_output_pattern = '\\033\['
expected_output_pattern = r'\\033\['
self.assertRegex(got_output, expected_output_pattern)


Expand Down