check if user to send message to is empty

[gerald2545]

check if mattermost user to send message to is empty (Users parameter in conf file)
in case Users is not empty, a call to mattermost was done to get the user id of Mattermost Username/accesstoken. This call was already done on first login. Si I set UserId attribute at login

Sorry, I didn't manage to make mage work (mage test : Unknown target specified: "test")

[c-seeger]

Thanks @gerald2545 for taking the time to create this pull request ❤️

[c-seeger]

should be more like

m.Error("Mattermost Error", map[string]interface{}{
"call": "PostMattermost",
"error": err
})

I think the "Email not set as synced" part can be removed this its now the correct default behavior.

[c-seeger]

Just for reference: putting additional information into the additional information part (map[string]interface) allows the logger to seperate this information and depending on the logging type (text/json) to seperate the fields so they can be read and parsed by a logging backend correctly

[c-seeger]

can you fix it pls

[c-seeger]

put the additional logging information into map[string]interface{}

m.Debug("writing to file", map[string]interface{
"filename": m.Config.General.File,
}

[c-seeger]

same here

[c-seeger]

m.Debug("login", map[string]interface{
"profile": profile,
})

no need to have this on Info logging

[c-seeger]

same here

[c-seeger]

m.Debug("user not found", map[string]interface{}{
  "error": resp.Error, 
  "email": email,
  "call": "GetUserByEmail",
  })

[gerald2545]

should be more precise I think
email sender not defined as mattermost user

[c-seeger]

how about

m.Debug("user not found", map[string]interface{}{
  "error": resp.Error, 
  "email": email,
  "call": "GetUserByEmail",
  "note": "email sender not defined as mattermost user",
  })

[c-seeger]

can be removed i guess?

[c-seeger]

same as the others, adding additional information as seperate

[c-seeger]

not sure if this is debug line is really needed since it's now catched with a proper error instead

[c-seeger]

map[string]interface{}{"length of user name": len(user)} since it is used to allow the logger to create parsable key value pairs the key should follow usual naming standards e.g: username_length. Also what benefit is created by this debug line providing user length as information for debugging?

[c-seeger]

for the mage part magefile

you can use mage to see all commands available, equal to make since mage is a make replacement but instead of a makefile you have a magefile that can be written in golang.

output should be sth. like this:

Targets:
  docker:cleanDocker    Clean - removes docker build files
  docker:docker         - creates docker container
  docker:init           - initializes docker build requirements
  release:all           - mage build all releases
  service:build         - mage build
  service:run           - mage run
  test:clean            - cleans up the client generation and binarys
  test:coverage         - checking code coverage
  test:run              - running tests and code coverage

relevant commands are mage test:run to run the tests (you can also just use the native go command go test -v ./...) and mage service:run so you can just run the code and see if it works with your configuration

[gerald2545]

OK, I'll test mage command, I guess I didn't use the right ones "mage test" instead of "mage test:run" and "mage build" instead of "mage service:build"

I used the "mage build" command as found in README > build it yourself, if it's not the right one you chould update it ;)

[gerald2545]

OK, I'll test mage command, I guess I didn't use the right ones "mage test" instead of "mage test:run" and "mage build" instead of "mage service:build"

I used the "mage build" command as found in README > build it yourself, if it's not the right one you chould update it ;)

with the right command, it works better ;)

[gerald2545]

README updated in this PR