Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling the plugin from source against UE 5.8.2 on Linux (Clang 20.1.8, bundled toolchain) produces several hard errors even on the latest master (which already has 5.8 support). These appear to be Linux/Clang-specific — likely not triggered on Windows/MSVC.
Fixes:
VoxelDiff.h: explicit template argument on operator<< collided with the engine's generic operator<< in StringBuilder.h (5.8 added C++20 concepts there).
VoxelDefaultPool.cpp: const members PriorityCategories/PriorityOffsets are now required to be initialized in the constructor's init list.
VoxelMathUtilities.h: XWayBlend_StrengthsToAlphas_Static overload was ambiguous under stricter overload resolution; constrained the "misuse" overload with std::enable_if_t.
VoxelWorld.cpp, ActorFactoryVoxelPlaceableItems.cpp, VoxelEditorToolsPanel.cpp: -Wunreachable-code-loop-increment treated as error by Clang 20; rewrote the "take first element" loops without the trailing increment.
.Build.cs files: disabled warnings-as-errors as a general safety net.
Tested on CachyOS Linux, UE 5.8.2, bundled Clang 20.1.8.