Do not create/update ServiceMonitor without verifying BasicAuth secrets #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fix can also be delivered (or re-delivered) into RCO once application-stacks/runtime-component-operator#414 (Share controller code further) is merged, and then this WLO PR can update its controller code to call RCO utils. That way, the basicAuth fix can be applied to RCO and all extending operators rather than just WLO alone. |
Contributor
|
Looks good to me for basicAuth. However, we might want to expand this check for other secret types. There are few supported by Prometheus (oauth2, authorization, bearerTokenSecret) |
- Validate Prometheus monitoring Secrets and ConfigMaps by breaking out of the reconcile loop if they do not exist. - Prevent validation of Secrets/ConfigMaps if the KeySelector's Optional parameter is set to true.
Member
|
@arturdzm please review the updates when you get a chance. Thanks |
Contributor
Author
|
Closing, because this change is replaced by PR #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does not allow creation or the updating of the Service Monitor if BasicAuth secrets are specified in the WSLA instance but do not actually exist.