/Sit Command (For Tank) #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement chair rotation
chatasma
reviewed
Jul 1, 2025
TTtie
suggested changes
Jul 1, 2025
src/main/kotlin/network/warzone/mars/player/listeners/tasks/ChairRotationTask.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/network/warzone/mars/player/listeners/tasks/ChairRotationTask.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/network/warzone/mars/player/controllers/SitController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/network/warzone/mars/player/controllers/SitController.kt
Outdated
Show resolved
Hide resolved
jorgeberrex
reviewed
Jul 2, 2025
There was a problem hiding this comment.
I like this idea but I feel like this is outside of the scope for Mars. As this feature does not rely on any kind of direct integration with Mars, I would propose moving this functionality to an entirely new plugin where some other fun features could be added. This way we can keep Mars strictly for server management and version-independent.
| import network.warzone.mars.player.controllers.SitController | ||
| import org.bukkit.Bukkit | ||
| import org.bukkit.Location | ||
| import org.bukkit.craftbukkit.v1_8_R3.entity.CraftArmorStand |
There was a problem hiding this comment.
This PR would break compatibility for modern server versions since you are directly using craftbukkit imports in some files.
Currently Mars does not have any utility functions for handling NMS/OBC imports so that would need to be implemented as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow players to use /sit command to sit down on the ground. Players in matches can use command but are unseated and take knockback as normal when hit